duig script - delete user in group

[wesley]

To delete a user, we need to edit the file : /etc/group, and remove manually the account. But if we need to remove many users, it will be very a big task.
So i built a small script that do it successfuly:

if [ $1 ] & [ $2 ]; then
cp /etc/group /tmp
cat /tmp/group | grep ^$2 > /tmp/onlygroup
cat /tmp/group | grep -v ^$2 > /tmp/nogroup
cat /tmp/onlygroup | sed "s/$1//g" | \
        sed "s/ /,/g" | sed "s/,,/,/g" | sed "s/,$//g" > /tmp/newgroup
cat /tmp/newgroup >> /tmp/nogroup
cat /dev/null > /tmp/group
cat /tmp/nogroup >> /tmp/group
cp /tmp/group /etc
chmod 644 /etc/group
chown root /etc/group
chgrp wheel /etc/group
rm -f /tmp/*
else
echo "Remove user from a group"
echo "Use : sh duig user group"
fi

Cheers,

Wesley MOUEDINE ASSABY
www.mouedine.net

[Carpetsmoker]

Unless I misunderstood something, this is a re-invention of pw(8).

[wesley]

On OpenBSD, remove user from group, can be done only modifing /etc/group.
Usermod -G, doesn't remove user on a group.

[Carpetsmoker]

Right, it wasn't clear that this is on OpenBSD.

You may also want to edit your first post and put the actual code inside [code] tags, this will preserve tabs and spaces, which will make your code much more readable.

[jggimi]

Wesley, I no longer bother responding to your threads here on Daemonforums. You duplicate the exact same question/issue/comment on misc@ each and every time.

[wesley]

To Jggimi : Misc@openbsd.org and DaemonForums.org are different *
The only stupid thing i done is to post 2 times here, first in "OpenBSD General" and second in "Guides", i'm agree with you.

[J65nko]

Please read the complete thread at http://marc.info/?l=openbsd-misc&m=129232689002840&w=2 before considering this script

[rocket357]

I made as I could, since it works, where is the problem...? ;-)

I had a job interview at Google last summer, and they asked me the question "You have a command to run on 100,000 machines. How do you approach it?" I wrote a very classy threaded Python program to utilize their existing key-based infrastructure to ssh simultaneously to all 100,000 machines as fast as my workstation could launch child threads. As each child thread successfully established an ssh connection, it would issue the command to the machine it was connected to. The program would then gather the results from each child thread in a directory hierarchy on my local machine so I could grep -R the output for issues. It was awesome....but it answered the wrong question. They asked about my approach (which by my program I implied "I'd just run the command, f*ck it"). They were looking for "I'd run it on a single test machine and wait a bit to see if it caused problems. If it appeared to be ok, I'd run it on a bigger group and wait again. If that was ok, I'd write a program (much like my python code) to run it on everyone."

Getting compliments from Google engineers about my coding style was nice, but I didn't get the job. Point is, it takes more than "it works" for it to be correct.

[IdOp]

Nits of widely varying sizes could be picked in OP's script, but I'll be content with one piece of low-hanging fruit, presumably run as root:

rm -f /tmp/*

!

[wesley]

After correction, i'm agree it is a bit long, but it works.
Thank you very much for your posts!

if [ $1 ] & [ $2 ]; then

tempfile=`mktemp /tmp/tempfile.XXXX`
cp /etc/group $tempfile

onlygroup=`mktemp /tmp/tempfile.XXXX`
cat $tempfile | grep ^$2 > $onlygroup

nogroup=`mktemp /tmp/tempfile.XXXX`
cat $tempfile | grep -v ^$2 > $nogroup

cat $onlygroup | sed "s/$1//g" | \
        sed "s/ /,/g" | sed "s/,,/,/g" | sed "s/,$//g" >> $nogroup

install -o root -g wheel -m 644 $nogroup /etc/group

rm -f /tmp/tempfile.????

else
echo "Remove user from a group"
echo "Use : sh duig user group"
fi

[ocicat]

Please, use [code] / [/code] tags when posting code. This isn't the first time someone has requested this action.

[J65nko]

The version I posted in http://marc.info/?l=openbsd-misc&m=129236670827180&w=2 is much shorter and simpler isn't it?

[wesley]

Good done !

[ocicat]

As opposed to spoon-feeding, I'm going to give you a point which is going to require thought on your part, Wesley.

Consider the following line of code:

tempfile=`mktemp /tmp/tempfile.XXXX`

...& what is done with it for the remainder of the script when multiple people are running the script on the same machine at the same time. Hint, it isn't good.

...but I'm a nice guy. I will even give you another hint. The answer for avoiding this problem can be found on Heiner's page:

http://www.shelldorado.com/

[wesley]

thanks!