torsmo displaying weather question

[neurosis]

Ive been reading on other forums "gentoo and ubuntu" that you can get torsmo to display the current weather. It looks rather simple though I dont know anything about programming or shell scripting. Here is a link to the thread.

http://forums.gentoo.org/viewtopic-t...rsmo+tips.html

Here is the code for the script.

#!/bin/bash
city="DeWitt"
link=USMI0231.html
file=/tmp/weather.txt
location=http://weather.yahoo.com/forecast/$link

lynx -accept_all_cookies -dump $location > $file
begin=`cat -n $file | grep "Currently" | cut -d ' ' -f5`
end=`expr $begin + 40`

head -n $end $file > tmp.t
tail -n 41 tmp.t > $file

case $1 in
   Today)  head -n 6 $file | sed '3d' ;;
   Tomorrow)
      begin=`cat -n $file | grep 'Today Tomorrow' | cut -d ' ' -f5`
      end=`cat -n $file | grep 'Extended' | cut -d ' ' -f5`
      num=`expr $end - $begin - 1`
      end2=`expr $begin + 7`

      head -n $end2 $file > tmp.t
      tail -n 3 tmp.t | sed 's/sky/\n sky/' | sed '4d' ;;
   *) exit ;;
esac

rm tmp.t
rm $file

When I run this I get an error.

$ ./tweather.sh
expr: syntax error
head: illegal line count -- /tmp/weather.txt

Can anyone offer suggestions as to why this isnt working?

[J65nko]

To see where the error is, run the script with debugging enabled

$ sh -vx ./tweather.sh

[neurosis]

Originally Posted by J65nko

To see where the error is, run the script with debugging enabled

$ sh -vx ./tweather.sh

$ sh -vx ./tweather.sh
#!/usr/local/bin/bash
city="Ogden, UT"
+ city=Ogden, UT
link=USUT0020.html
+ link=USUT0020.html
file=/tmp/weather.txt
+ file=/tmp/weather.txt
location=http://weather.yahoo.com/forecast/$link
+ location=http://weather.yahoo.com/forecast/USUT0020.html

lynx -accept_all_cookies -dump $location > $file
+ lynx -accept_all_cookies -dump http://weather.yahoo.com/forecast/USUT0020.html
begin=`cat -n $file | grep "Currently" | cut -d ' ' -f5`
+ + grep Currently
cat -n /tmp/weather.txt
+ cut -d   -f5
+ begin=
end=`expr $begin + 40`
+ expr + 40
expr: syntax error
+ end=

head -n $end $file > tmp.t
+ head -n /tmp/weather.txt
head: illegal line count -- /tmp/weather.txt
tail -n 41 tmp.t > $file
+ tail -n 41 tmp.t

case $1 in
   Today)  head -n 6 $file | sed '3d' ;;
   Tomorrow)
      begin=`cat -n $file | grep 'Today Tomorrow' | cut -d ' ' -f5`
      end=`cat -n $file | grep 'Extended' | cut -d ' ' -f5`
      num=`expr $end - $begin - 1`
      end2=`expr $begin + 7`

      head -n $end2 $file > tmp.t
      tail -n 3 tmp.t | sed 's/sky/\n sky/' | sed '4d' ;;
   *) exit ;;
esac
+ exit

I dont know what all of this means. I see an expression error?

[ephemera]

Maybe change this:
begin=`cat -n $file | grep "Currently" | cut -d ' ' -f5`

to:
begin=`cat -n $file | grep "Current" | cut -d ' ' -f5`

[neurosis]

Originally Posted by ephemera

Maybe change this:
begin=`cat -n $file | grep "Currently" | cut -d ' ' -f5`

to:
begin=`cat -n $file | grep "Current" | cut -d ' ' -f5`

Worked. That was something very simple too. Sometimes this kind of thing makes me think I lack commons sense skills.

Thank you. I'll test this when I get home

[BSDfan666]

The script needs to be adapted to changes in yahoo's website...

It searches for the word "Currently" in the dumped page... as it doesn't exist, some of the scripts variables don't get properly set.. in the end, kaboom.

Moral of the story: Don't write scripts that assume a page will stay the same forever.

Yahoo offers RSS/XML streams, try writing a script to parse that mess..

[J65nko]

$ sh -vx ./tweather.sh
#!/usr/local/bin/bash
city="Ogden, UT"
+ city=Ogden, UT
link=USUT0020.html
+ link=USUT0020.html
file=/tmp/weather.txt
+ file=/tmp/weather.txt
location=http://weather.yahoo.com/forecast/$link
+ location=http://weather.yahoo.com/forecast/USUT0020.html

The lines not prefixed with a '+' are the source. The '+' lines show the result..

begin=`cat -n $file | grep "Currently" | cut -d ' ' -f5`
+ + grep Currently
cat -n /tmp/weather.txt
+ cut -d   -f5
+ begin=

Here you see that the variable 'begin' has no value.

end=`expr $begin + 40`
+ expr + 40
expr: syntax error
+ end=

Because 'begin' is empty, the expr command fails and also leaves the variable 'end' empty.

head -n $end $file > tmp.t
+ head -n /tmp/weather.txt

Here the '+' lines shows that 'end' is empty, so no line count is passed to the head utility.

head: illegal line count -- /tmp/weather.txt

Not that difficult isn't it?