Automation Script

[ninjatux]

I use this script in Mac OS X to handle some startup actions that I need automated. What do you think of the script? It runs well, but would you do it this way or another way?

# startup_actions (Automator action-"Run Shell Script")

# Set appropriate PATH variable
export PATH=/opt/local/bin:/opt/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin

# Wait 3 seconds for WiFi to come up
sleep 3

# Variable declarations
LOCAL_IP_TEST=192.168
LOCAL_IP=192.168.2.4
EXT_IP=67.84.74.65
TEST_SITE=www.google.com
MOUNT_PT=/Volumes/starbox_ninjasb
count=3

if [ 'ping -c $count "$TEST_SITE"' ] # Test for network connection
then
	# Create mount point if necessary
	if [ ! -e "$MOUNT_PT" ]
	then
		mkdir "$MOUNT_PT"
	fi

	# Mount /home/ninjasb@starbox via sshfs
	if ifconfig | grep "$LOCAL_IP_TEST" > /dev/null # Test connection type for local or ext
	then
		sshfs ninjasb@"$LOCAL_IP":/home/ninjasb "$MOUNT_PT" -oreconnect,volname=starbox_ninjasb
	else
		sshfs ninjasb@"$EXT_IP":/home/ninjasb "$MOUNT_PT" -oreconnect,volname=starbox_ninjasb
	fi
	
	# Start mpd if it isn't already running
	if [ -z $(pidof mpd) ]
	then
		sleep 1; mpd # Wait for sshfs mount to settle, then run mpd
	fi
else
	exit 0 # Fail-no internet connection
fi

[J65nko]

You can replace

	# Create mount point if necessary
	if [ ! -e "$MOUNT_PT" ]
	then
		mkdir "$MOUNT_PT"
	fi

with a simpler

mkdir -p ${MOUNT_PT}

I would echo some information about the actions taken

# Mount /home/ninjasb@starbox via sshfs
echo $0 Testing connection type for local or ext ...
if ifconfig | grep "$LOCAL_IP_TEST" > /dev/null ; then
    echo $0: Using local IP address: ${LOCAL_IP}
    IP=${LOCAL_IP}
else
    echo $0: Using external  IP address : ${EXT_IP}
    IP=${EXT_IP}
fi

echo $0 : mounting in progress ....
sshfs ninjasb@"${IP}":/home/ninjasb "$MOUNT_PT" -oreconnect,volname=starbox_ninjasb

Doing something similar for the mpd connection is left as an exercise

[anomie]

I'd paint that bike shed like this:

#!/bin/sh

<init vars here> 

mount_it() {

  echo "Attempting to mount to ${1}..."

  # If connect scan to tcp 22 works, then mount
  ( nc -z -w 2 ${1} 22 >/dev/null ) && <sshfs mount ${1} here>

  # If that all worked, we get out
  if [ ${?} -eq 0 ] ; then
    echo 'Mounted.'
    exit 0
  fi

}

mount_it ${local_ip}
mount_it ${external_ip}

exit 0

netcat (nc) should be included with your Mac OSX base system.